Conversation
To make the app run on Expo 55, there were a few more packages that needed updating. Also, I've added Expo UI to use for our components.
Expo's recommendations now are to use the `<Host />` component in JS land instead.
Expo's guidance is to set `matchContents` on the `<Host />` component in JS.
This is to prevent the button from collapsing when in it's being centrally aligned in a flex box layout.
|
@greptileai, can you please review this PR? |
cameronapak
left a comment
There was a problem hiding this comment.
Hey Andrew, good work. As long as this works, it looks good to me. I don't see any issues. Thank you for doing the meticulous hard work for getting this upgraded!
|
One flag posed by Devin AI is:
If this is relevant, please follow suit |
This is a good callout and I can see how it can be confusing/misleading. The |
Greptile SummaryThis PR upgrades the SDK from Expo SDK 54 to SDK 55, migrating all native view modules and TypeScript components to the new Key changes:
The migration is implemented consistently across all platforms and the previously flagged concerns (dead Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant JS as React (TypeScript)
participant Host as Host (@expo/ui/swift-ui)
participant NV as NativeView (requireNativeView)
participant Mod as ExpoUIView Module (Swift)
participant SwiftUI as ExpoSwiftUI.View (Swift)
JS->>Host: render with style / matchContents
Host->>NV: render child with props
NV->>Mod: bridge call (ExpoUIView)
Mod->>SwiftUI: instantiate YVP*View(props:)
SwiftUI-->>Mod: SwiftUI body (BibleTextView / VotdView / etc.)
Mod-->>NV: rendered native frame
NV-->>Host: sized native view
Host-->>JS: final laid-out component
Reviews (2): Last reviewed commit: "chore: require expo ui to be SDK 55 or h..." | Re-trigger Greptile |
Description
Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Breaking Changes
Breaking Change Details:
Migration Guide:
Checklist